Package Details: cemu 2.4-2

Git Clone URL: https://aur.archlinux.org/cemu.git (read-only, click to copy)
Package Base: cemu
Description: Software to emulate Wii U games and applications on PC
Upstream URL: https://cemu.info
Keywords: emulator wii-u
Licenses: MPL2
Submitter: Anuskuss
Maintainer: kescherAUR
Last Packager: kescherAUR
Votes: 29
Popularity: 2.53
First Submitted: 2022-09-05 15:23 (UTC)
Last Updated: 2024-12-01 18:41 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 Next › Last »

kescherAUR commented on 2023-01-08 22:18 (UTC)

@Max-P ah, sorry. yep, it seems you were right. I didn't test enough then.

Max-P commented on 2023-01-08 22:05 (UTC)

It looks like ${CC-} wasn't quite enough to not trip errexit. It looks like to be because assigning the return value of a failed command to a variable is not enough to satisfy strict mode.

echo $(false) # ok
test=$(false) # error

So I think we'll have to add the || true anyway to make it work, because now even though the ${CC-} fixes the unbound variable, the test expression [[ ... ]] still returns false, so the whole $(...) expression is false.

To test:

bash -eux PKGBUILD && echo OK || echo FAIL

kescherAUR commented on 2022-12-29 06:12 (UTC)

v2.0-25 fixes an issue for macOS only, as far as I can tell.

kescherAUR commented on 2022-12-28 21:32 (UTC) (edited on 2022-12-28 21:38 (UTC) by kescherAUR)

The v2.0-24 tag was just published. However, the two tags are identical. It's only to trigger a rebuild for the project's CI that builds their AppImage. Therefore, I am not updating the package to it.

kescherAUR commented on 2022-12-27 14:19 (UTC)

Since upstream highly suggests using clang (https://github.com/cemu-project/Cemu/blob/main/BUILD.md#for-arch-and-derivatives), I might actually just remove that check as a whole at some point. For now, I'll simply apply the fix (without the || true, as both variables being expanded to either a set or an empty value suffices for strict mode).

Thanks for pointing out the issue, @Max-P.

Max-P commented on 2022-12-20 04:55 (UTC)

This package doesn't build with aurutils due to it running bash in strict mode (set -eu).

I would recommend adding || true to the clang makedepends, like this:

$([[ $CC+$CXX == *clang* ]] && echo 'clang>=12 llvm>=12' || true)

Basically the issue is that $CC and $CXX may not exist, which throws an error that needs to be caught by adding the || true as a fallback.

That said, I'm curious as to what is the purpose of adding this to makedepends if its use is conditional to the user already specifying they want to compile with clang? Obviously the dependency is going to exist already, so I don't see a reason to marking it as a makedepend in the first place. It's not required to build cemu therefore it shouldn't be there, at best it's an optional makedepend which isn't really a thing. The user is already specifying an overriden compiler, I don't think it's the package's job to care at that point. PKGBUILDs also expect a fully up to date system by definition, so specifying clang>=12 is also a bit redundant, as the current version is 14.0.6.

kescherAUR commented on 2022-12-15 22:44 (UTC)

@WillTreaty which is part of the base-devel group. https://wiki.archlinux.org/title/PKGBUILD#makedepends

eclairevoyant commented on 2022-12-15 22:43 (UTC)

@WillTreaty No it doesn't; search on the wiki about the AUR and read section 1.

« First ‹ Previous 1 2 3 4 5 6 7 8 9 Next › Last »