Package Details: fish-git 2:4.0b1.r101.gd5efef1cc-1

Git Clone URL: https://aur.archlinux.org/fish-git.git (read-only, click to copy)
Package Base: fish-git
Description: User friendly shell intended mostly for interactive use.
Upstream URL: https://github.com/fish-shell/fish-shell
Keywords: shell
Licenses: GPL-2.0-only AND BSD-3-Clause AND ISC AND MIT AND PSF-2.0
Conflicts: fish, fish-shell
Provides: fish, fish-shell
Submitter: SanskritFritz
Maintainer: SanskritFritz (akiirui)
Last Packager: akiirui
Votes: 72
Popularity: 2.23
First Submitted: 2010-11-17 22:27 (UTC)
Last Updated: 2024-12-31 11:05 (UTC)

Dependencies (13)

Required by (85)

Sources (1)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 .. 16 Next › Last »

akiirui commented on 2024-02-07 08:05 (UTC)

@ptr1337 Did you get an error when compiling after enabling lto this time? Please post your log, because I tested it after enabling it and it can be compiled.

ptr1337 commented on 2024-02-07 06:39 (UTC)

@akiirui

Could you please add options=(!lto)?

This got mentioned already multiple times, but you didnt add this. Please follow the archlinux packaging guidelines and the package should be possible to build in a chroot with the DEFAULT makepkg.conf, which does enable lto as default.

Please fix, it is really annoying since our weekly git build does fail due to this.

akiirui commented on 2024-02-05 01:11 (UTC)

@FreeFull Fixed.

FreeFull commented on 2024-02-04 15:13 (UTC)

Something changed upstream, and now this PKGBUILD doesn't seem to work any more. Getting the following errors at the end of the build process:

Error copying file "/home/freefull/AUR/fish-git/src/fish-shell/build/cargo/build/x86_64-unknown-linux-gnu/release/fish_key_reader" to "/home/freefull/AUR/fish-git/src/fish-shell/build".
Error copying file "/home/freefull/AUR/fish-git/src/fish-shell/build/cargo/build/x86_64-unknown-linux-gnu/release/fish_indent" to "/home/freefull/AUR/fish-git/src/fish-shell/build".
make[2]: *** [CMakeFiles/fish_indent.dir/build.make:70: CMakeFiles/fish_indent] Error 1
make[1]: *** [CMakeFiles/Makefile2:583: CMakeFiles/fish_indent.dir/all] Error 2
Error copying file "/home/freefull/AUR/fish-git/src/fish-shell/build/cargo/build/x86_64-unknown-linux-gnu/release/fish" to "/home/freefull/AUR/fish-git/src/fish-shell/build".
make[2]: *** [CMakeFiles/fish.dir/build.make:70: CMakeFiles/fish] Error 1
make[1]: *** [CMakeFiles/Makefile2:557: CMakeFiles/fish.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
make: Leaving directory '/home/freefull/AUR/fish-git/src/fish-shell/build'

rien333 commented on 2023-02-23 09:45 (UTC)

@akiirui Cool! Might report it to upstream if this behavior stays around.

akiirui commented on 2023-02-23 09:28 (UTC)

@rien333 Reproduced, thanks for the feedback.

rien333 commented on 2023-02-23 09:23 (UTC) (edited on 2023-02-23 09:24 (UTC) by rien333)

This doesn't build if you have lto enabled in /etc/makepkg.conf — to be specific, it fails during the linking step. Seems like a recent "regression" (?), since this didn't happen before the rust switch.

Adding this to the PKGBUILD makes it work, however:

options=('!lto')

SanskritFritz commented on 2023-02-20 21:33 (UTC)

Awesome man, thanks for the new version!

akiirui commented on 2023-02-20 03:46 (UTC)

you sure about clang being a hard-dependency? the readme states "a C++11 compiler (g++ 4.8 or later, or clang 3.3 or later)"

Yep, I'm sure it requires clang to build the package.

Ref: https://github.com/fish-shell/fish-shell/pull/9512#issuecomment-1409060148

And logs without clang

CXX include path:
    /build/fish-git/src/fish-shell/build/./cargo/build/x86_64-unknown-linux-gnu/release/build/fish-rust-24bfa284ef858128/out/cxxbridge/include
    /build/fish-git/src/fish-shell/build/./cargo/build/x86_64-unknown-linux-gnu/release/build/fish-rust-24bfa284ef858128/out/cxxbridge/crate
  thread 'main' panicked at 'Unable to find libclang: "couldn't find any valid shared libraries matching: ['libclang.so', 'libclang-*.so', 'libclang.so.*', 'libclang-*.so.*'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"', /build/.cargo/git/checkouts/autocxx-bindgen-d188c39f50b02e88/a229d34/./lib.rs:2397:31
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

also, would you like to be co-maintainer akiirui?

Yes.

SanskritFritz commented on 2023-02-19 20:54 (UTC)

also, would you like to be co-maintainer akiirui?