Package Details: fish-git 2:4.0b1.r101.gd5efef1cc-1

Git Clone URL: https://aur.archlinux.org/fish-git.git (read-only, click to copy)
Package Base: fish-git
Description: User friendly shell intended mostly for interactive use.
Upstream URL: https://github.com/fish-shell/fish-shell
Keywords: shell
Licenses: GPL-2.0-only AND BSD-3-Clause AND ISC AND MIT AND PSF-2.0
Conflicts: fish, fish-shell
Provides: fish, fish-shell
Submitter: SanskritFritz
Maintainer: SanskritFritz (akiirui)
Last Packager: akiirui
Votes: 72
Popularity: 3.15
First Submitted: 2010-11-17 22:27 (UTC)
Last Updated: 2024-12-31 11:05 (UTC)

Dependencies (13)

Required by (87)

Sources (1)

Latest Comments

1 2 3 4 5 6 .. 15 Next › Last »

aorth commented on 2024-12-31 15:17 (UTC)

@akiirui interesting! I was building with an aur chroot. You're right that it works with extra-x86_64-build. Maybe my other chroot has an outdated config or something. I see that a shortcut is pkgctl build and that reminds me to check out the new pkgctl tool.

akiirui commented on 2024-12-31 09:58 (UTC) (edited on 2024-12-31 10:40 (UTC) by akiirui)

@aorth

I can't reproduce these two failures in a clean chroot (extra-x86_64-build)

More case, I was able to reproduce the failure tests::fd_monitor::test_close_during_select_ebadf (in a chroot with tmux installed), but was unable to reproduce the failure tests::history::test_history_races.

aorth commented on 2024-12-31 08:03 (UTC) (edited on 2024-12-31 08:04 (UTC) by aorth)

Getting failed tests in cargo-test:

thread 'tests::history::test_history_races' panicked at src/tests/history.rs:339:5:
assertion `left == right` failed
  left: 1019
 right: 1025

failures:
    tests::fd_monitor::test_close_during_select_ebadf
    tests::history::test_history_races

test result: FAILED. 186 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 12.10s

error: test failed, to rerun pass `-p fish --lib`

Building in a chroot.

swsnr commented on 2024-12-19 11:42 (UTC) (edited on 2024-12-19 11:43 (UTC) by swsnr)

I'd like to point out that the license appears to be incorrect. https://github.com/fish-shell/fish-shell/blob/master/doc_src/license.rst does not include the "or later" clause; going by this file a more accurate license expression would probably be "GPL-2.0-only AND LGPL-2.0-only AND MIT AND PSF-2.0".

akiirui commented on 2024-10-26 06:21 (UTC)

@jaxvanyang The skippable checks are probably not important. And extra/fish doesn't depend on them either. If the official repository packages include them, I'll add it.

You can add these to

checkdepends=(
  'expect'
  'procps-ng'
)

jaxvanyang commented on 2024-10-26 04:28 (UTC)

Some tests are skipped if less and tmux are not installed. How about adding them to checkdepends to enable all tests?

akiirui commented on 2024-10-16 16:35 (UTC)

@jaxvanyang Thanks for the report, done.

jaxvanyang commented on 2024-10-16 12:11 (UTC) (edited on 2024-10-16 13:06 (UTC) by jaxvanyang)

After replacing fish with this and reboot. I can't login using any account which uses fish as login shell (Gnome and TTY). Replacing back fixes it. It's really weird, not sure if my environment broken. If someone has the same problem as me, we should open an issue upstream.

It turns out this is a configuration problem. fish provides both /bin/fish and /usr/bin/fish in /etc/shells. I set my login shell to /bin/fish, but fish-git only set /usr/bin/fish, which makes /bin/fish an invalid login shell, so I can't login.

@SanskritFritz @akiirui I think it would be better to use the same fish.install from https://gitlab.archlinux.org/archlinux/packaging/packages/fish

akiirui commented on 2024-07-07 03:42 (UTC)

@xiota Done, thanks.