Package Details: mcpelauncher-linux 1.1.2-1

Git Clone URL: https://aur.archlinux.org/mcpelauncher-linux.git (read-only, click to copy)
Package Base: mcpelauncher-linux
Description: Minecraft: Pocket Edition launcher for Linux
Upstream URL: https://github.com/minecraft-linux/mcpelauncher-manifest
Licenses: GPL-3.0-only
Provides: mcpelauncher-client
Submitter: HurricanePootis
Maintainer: HurricanePootis
Last Packager: HurricanePootis
Votes: 4
Popularity: 0.98
First Submitted: 2024-06-12 01:51 (UTC)
Last Updated: 2024-12-06 23:48 (UTC)

Required by (2)

Sources (32)

Latest Comments

asalde_le1 commented on 2024-08-19 08:07 (UTC)

@HurricanePootis Thank you very much for your kind words and for your work on this package!

HurricanePootis commented on 2024-08-19 03:55 (UTC)

@asalde_le1

Don't be sorry that you asked questions. Asking questions is the best way to learn. Sorry if I came across rude. You did a good thing reaching out to me with your concerns, even if in the end they ended up being not true. Without you, I wouldn't have gone again and checked the flags to get it building. So, thank you for motivating me to do a deeper check!

asalde_le1 commented on 2024-08-19 03:30 (UTC)

@HurricanePootis thank you for the detailed answer. Sorry if some of my questions were dumb.

HurricanePootis commented on 2024-08-19 03:05 (UTC) (edited on 2024-08-19 03:42 (UTC) by HurricanePootis)

@asalde_le1

  1. Setting DCMAKE_BUILD_TYPE to Release is not advised by the CMake package guidelines, as it overrides the makeflags set for Arch Linux
  2. The reason why you thinking specifying -stdlib=c++17 fixed the issue is because by giving cmake the arugment -DCMAKE_CXX_FLAGS="-stdlib=c++17", you are not passing along the $CXXFLAGS variable to Cmake as defined in /etc/makepkg.conf, where the -Wp,-D_FORTIFY_SOURCE-3 is. The project currently builds and is able to run as is. If the project requires C++17, then it will be automatically set in Cmake as needed by the developers. Edit: mcpelauncher-manifest's CMakeLists.txt does set C++17 as a standard, no need for the flag.
  3. If you would to read the PKGBUILD, -DENABLE_DEV_PATHS=OFF is already set

asalde_le1 commented on 2024-08-19 00:23 (UTC)

Also please add -DENABLE_DEV_PATHS=OFF option and change DCMAKE_BUILD_TYPE to Release. And the v1.0.0-qt6 version is released

asalde_le1 commented on 2024-08-19 00:01 (UTC)

@HurricanePootis in ci configs in official repos they specify c++ 17 standard, that fixes the problem for me. Maybe the better way is to specify 17 standard?

HurricanePootis commented on 2024-08-18 18:12 (UTC)

@asalde_le1 the problem was not the C++ standard, it was -Wp,-D_FORTIFY_SOURCE=3. I am pushing an update rn to fix this.

asalde_le1 commented on 2024-08-18 15:32 (UTC) (edited on 2024-08-18 16:29 (UTC) by asalde_le1)

The problem is that by default the compiler uses C++ 14 instead of 17, that is required. Here is the patch to fix this problem:

diff --git a/PKGBUILD b/PKGBUILD
index 8815f6e..cf32916 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -133,7 +133,8 @@ build() {
     -B build -DCMAKE_INSTALL_PREFIX=/usr \
     -DCMAKE_BUILD_TYPE=RelWithDebInfo \
     -DENABLE_DEV_PATHS=OFF \
-    -Wno-dev
+    -Wno-dev \
+    -DCMAKE_CXX_FLAGS="--std=c++17"
   cmake --build build --parallel
 }

HurricanePootis commented on 2024-07-28 10:10 (UTC) (edited on 2024-08-18 19:35 (UTC) by HurricanePootis)

The issue has been reported to the github here. According to chats in the discord, a compiler / stdlib update has removed a feature that libc-shim relied on, and sounds like it will require a rewrite. Please be patient in the meantime, and go install mcpelauncher-appimage

Edit: The issue has been fix as of 0.15.2-2

NyaomiDEV commented on 2024-07-26 15:19 (UTC) (edited on 2024-07-26 15:20 (UTC) by NyaomiDEV)

Trying to build ver. 0.15.2-1 fails on my system with Makefile error 2:

./mcpelauncher-linux/src/mcpelauncher-manifest/libc-shim/src/cstdio.cpp:140:10: error: no matching member function for call to 'insert'