Package Details: mozillavpn 2.24.3-1

Git Clone URL: https://aur.archlinux.org/mozillavpn.git (read-only, click to copy)
Package Base: mozillavpn
Description: Fast, secure, and easy to use VPN from the makers of Firefox
Upstream URL: https://vpn.mozilla.org
Keywords: vpn wireguard
Licenses: MPL-2.0
Submitter: tavianator
Maintainer: Xavier (xiota)
Last Packager: Xavier
Votes: 43
Popularity: 0.82
First Submitted: 2021-01-13 02:38 (UTC)
Last Updated: 2024-11-06 07:01 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 .. 22 Next › Last »

PolarianDev commented on 2023-12-13 10:16 (UTC)

I am aware that glean-parser is not preferable, but this package doesn't conform to simplicity. [1]

Debian seems to have heavily modified the sources to suit their needs, this conflicts the Arch way of doing things.

I doubt staff would mind a mozillavpn-patched or a package with the debian patchset like mozillavpn-debian or something, but the main package should be conforming to the Arch Principles, which it currently doesn't.

[1] https://wiki.archlinux.org/title/Arch_Linux#Simplicity

Xavier commented on 2023-12-11 14:15 (UTC)

Fixed, thanks so much Xiota, if you want to be a co-maintainer please let me know

Xavier commented on 2023-12-08 13:28 (UTC) (edited on 2023-12-08 13:30 (UTC) by Xavier)

You are absolutely right about the systemctl services, I was testing that before updating it, and I forgot to change it, fixed it. Again, it does not use a binary packages, this is builting from the source code, but not using the github source code, using a prepare source code instead, why? to remove the glean dependency and other preprocessing steps, making this a faster and lighter process, then why not?

Antiz commented on 2023-12-08 10:24 (UTC) (edited on 2023-12-08 10:45 (UTC) by Antiz)

In addition to @gromit's comment, is there any reason why you replaced upstream sources by Ubuntu's ones?

Also, you're not supposed to enable/start systemd units automatically via a post_install script. This has to be done explicitly by users.

Please remove that post_install script and consider switching back sources to upstream's ones (unless there's a good reason to use Ubuntu's ones instead?).

Edit: I just saw the comment about the sources switch. Sorry I missed it.

gromit commented on 2023-12-08 10:13 (UTC)

As per the AUR Submission Guidelines you should leave the attribution to previous contributors on top of the pkgbuild:

If there were previous maintainers, put them as contributors. The same applies for the original submitter if this is not you. If you are a co-maintainer, add the names of the other current maintainers as well.

So please undo that part of 7e097f9c114d :)

tesfabpel commented on 2023-12-08 09:04 (UTC) (edited on 2023-12-08 09:08 (UTC) by tesfabpel)

The new 2.19.0 version of this package added a mozillavpn.install step which auto-enables and auto-starts the service. I think it's better to do it manually on Arch, as it is customary to do so here AFAIK (I had to manually start / enable all the other services when installing their packages, like eg. TeamViewer)... Thanks, anyway! :)

Xavier commented on 2023-12-08 03:28 (UTC)

Thanks @xiota, but I'm going to use the easier and simpler method of using the prepared Ubuntu source tar package (no-binary). This package is ready to build, avoiding potential issues with glean, submodules and other preprocessing steps, that in the end, we get the same binary but through a lightweight and simple process. Important to mention that this Ubuntu source tar package is official by the mozillavpn developers, and this preprocess is in the github actions in the mozillavpn repository.

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 .. 22 Next › Last »