Arch Linux User Repository

Pull requests are welcome here: https://github.com/kxxt/aur-onlyoffice

You can also report issues at the GitHub repo.

@dreieck 8.1.1-2 should fix the issues you found. Thanks again for your report.

prepare() does throw errors pathspec 'v8.1.1' did not match any file(s) known to git,

I didn't notice this before. It looks like a problem. Thanks for your report! I will look into it.

syntax warnings invalid escape sequence

That's just some bad python code from upstream. They even use semicolons sometimes in python scripts.

error AttributeError: module 'boost' has no attribute 'make', and fails:

Could you try building in a clean chroot(for example, by using extra-x86_64-build)? I always build packages in clean chroot.I suspect this is because onlyoffice's script wants to import a local 'boost' module but it uses the globally installed one in your case.

Also, note, that prepare() still downloads stuff.

Yes, it still clones tons of git repos of boost. Ideally I want to get rid of it. But IMO this is Arch and prepare() is allowed to download stuff.

prepare() does throw

• errors pathspec 'v8.1.1' did not match any file(s) known to git,
• error AttributeError: module 'boost' has no attribute 'make',
• syntax warnings invalid escape sequence

and fails:

==> Starting prepare()...
[...]
patching file scripts/package_branding.py
/var/cache/makepkg/build/onlyoffice/src/build_tools/scripts/base.py:976: SyntaxWarning: invalid escape sequence '\.'
  return re.sub("[^a-zA-Z0-9\.\-]", "-", bundle_identifier)
/var/cache/makepkg/build/onlyoffice/src/build_tools/scripts/base.py:1432: SyntaxWarning: invalid escape sequence '\d'
  sdks = [re.findall('^MacOSX(1\d\.\d+)\.sdk$', s) for s in os.listdir(sdk_dir)]
/var/cache/makepkg/build/onlyoffice/src/build_tools/scripts/base.py:1630: SyntaxWarning: invalid escape sequence '\$'
  new_path = new_path.replace("$ORIGIN", "\$ORIGIN")
/var/cache/makepkg/build/onlyoffice/src/build_tools/scripts/develop/dependence.py:647: SyntaxWarning: invalid escape sequence '\q'
  result = os.system(postgreLoginSrt + ' -c "\q"')
/var/cache/makepkg/build/onlyoffice/src/build_tools/scripts/develop/dependence.py:697: SyntaxWarning: invalid escape sequence '\d'
  if (base.run_command_in_dir(postgre_path_to_bin, postgreLoginRoot + ' -c "\du ' + dbUser + '"')['stdout'].find(dbUser) != -1):
/var/cache/makepkg/build/onlyoffice/src/build_tools/scripts/develop/dependence.py:699: SyntaxWarning: invalid escape sequence '\q'
  if (os.system(postgreLoginDbUser + '-c "\q"') != 0):
/var/cache/makepkg/build/onlyoffice/src/build_tools/scripts/develop/dependence.py:719: SyntaxWarning: invalid escape sequence '\l'
  if (base.run_command_in_dir(postgre_path_to_bin, postgreLoginRoot + '-c "\l+ ' + dbName + '"')['stdout'].find(dbUser +'=CTc/' + rootUser) == -1):
[git] update: core
error: pathspec 'v8.1.1' did not match any file(s) known to git
branch does not exist...
switching to master...
Already on 'master'
Your branch is up to date with 'origin/master'.
Already up to date.
[git] update: sdkjs
error: pathspec 'v8.1.1' did not match any file(s) known to git
[...]
[git] update: sdkjs-forms
error: pathspec 'v8.1.1' did not match any file(s) known to git
[...]
[git] update: onlyoffice.github.io
error: pathspec 'v8.1.1' did not match any file(s) known to git
[...]
[git] update: web-apps
error: pathspec 'v8.1.1' did not match any file(s) known to git
[...]
[git] update: dictionaries
error: pathspec 'v8.1.1' did not match any file(s) known to git
[...]
[git] update: core-fonts
error: pathspec 'v8.1.1' did not match any file(s) known to git
[...]
[git] update: desktop-sdk
error: pathspec 'v8.1.1' did not match any file(s) known to git
[...]
[git] update: desktop-apps
error: pathspec 'v8.1.1' did not match any file(s) known to git
[...]
[git] update: document-templates
error: pathspec 'v8.1.1' did not match any file(s) known to git
[...]
patching file win-linux/src/cthemes.cpp
Traceback (most recent call last):
  File "/var/cache/makepkg/build/onlyoffice/src/build_tools/./make.py", line 73, in <module>
    make_common.make()
  File "/var/cache/makepkg/build/onlyoffice/src/build_tools/scripts/core_common/make_common.py", line 39, in make
    boost.make()
    ^^^^^^^^^^
AttributeError: module 'boost' has no attribute 'make'
==> ERROR: A failure occurred in prepare().

Also, note, that prepare() still downloads stuff.

Regards!

Since Qt5 is now already outdated,

Yes, every dependency onlyoffice uses is outdated. They even use v8 8.9 that doesn't include any security patches. They also uses outdated CEF binary downloaded from an http url and doesn't check its integrity at all. Even worse, that CEF binary might be closed source as suggested by dbermond in https://github.com/ONLYOFFICE/DesktopEditors/issues/1664

I would advise anyone who uses onlyoffice to avoid opening any untrusted documents with it. It appears that onlyoffice upstream doesn't care about security at all. See https://github.com/ONLYOFFICE/DesktopEditors/issues/1664 for more details

can you switch to Qt6, or drop Qt support, or rename the package to onlyoffice-qt5 (and adding proper provides=("onlyoffice=${pkgver}"), conflicts=("onlyoffice"))?

@dreieck That's no really up to me. AFAIK onlyoffice only supports and requires qt5 and it does not support building with qt6. But if you can put together a patch for qt6 support, I would recommend you to open a PR in onlyoffice repo. Thanks!

Can you also pin onlyoffice-core git repository, and all the other unversioned git repositories you use, to a specific commit, please?

That's no necessary because ./configure.py --branch "v$pkgver" will checkout the git repos to the correct revision. But having said that, I didn't verify whether that script really achieves that. I don't put too much trust on the onlyoffice upstream now. I agree that pinning them in sources would be an improvement.

Since Qt5 is now already outdated, can you

• switch to Qt6, or
• drop Qt support, or
• rename the package to onlyoffice-qt5 (and adding proper provides=("onlyoffice=${pkgver}"), conflicts=("onlyoffice"))?

Regards!

Can you also pin onlyoffice-core git repository, and all the other unversioned git repositories you use, to a specific commit, please?

Since this here is not a VCS package but a fixed version package, users should expect to get the same source for the same $pkgver.

Regards and thanks for the package!

Pull requests are welcome here: https://github.com/kxxt/aur-onlyoffice

You can also report issues at the GitHub repo.