Arch Linux User Repository

Thanks @a821, I have applied the patch and check fix, works here too.

Just to let you know that the patch of my previous comment in the PKGBUILD works; it builds in a clean chroot. The only thing is that you need to add export LANG=C in the check() function to make the checks pass (you can see the same line in the official postgresql package).

There's a patch on the postgresql mailing list that it seems to work [1]. Unfortunately, the patch does no apply cleanly, so I modified it a bit. At least the command make world passes. Further work is needed to include it in the PKGBUILD though.

[1] https://www.postgresql.org/message-id/CACpMh%2BDMZVHM%2BiDSyqdcpK8sr7jd_HxxLJRNvGTzcLBE0W07QA%40mail.gmail.com

the patch:

--- postgresql-12.17/src/backend/utils/adt/xml.c.orig   2023-11-06 23:11:55.000000000 +0100
+++ postgresql-12.17/src/backend/utils/adt/xml.c    2024-01-09 17:34:53.613808376 +0100
@@ -119,7 +119,11 @@

 static xmlParserInputPtr xmlPgEntityLoader(const char *URL, const char *ID,
                                           xmlParserCtxtPtr ctxt);
+#if LIBXML_VERSION >= 21200
+static void xml_errorHandler(void *data, const xmlError *error);
+#else
 static void xml_errorHandler(void *data, xmlErrorPtr error);
+#endif
 static void xml_ereport_by_code(int level, int sqlcode,
                                const char *msg, int errcode);
 static void chopStringInfoNewlines(StringInfo str);
@@ -1751,8 +1755,12 @@
 /*
  * Error handler for libxml errors and warnings
  */
+#if LIBXML_VERSION >= 21200
+static void xml_errorHandler(void *data, const xmlError *error)
+#else
 static void
 xml_errorHandler(void *data, xmlErrorPtr error)
+#endif
 {
    PgXmlErrorContext *xmlerrcxt = (PgXmlErrorContext *) data;
    xmlParserCtxtPtr ctxt = (xmlParserCtxtPtr) error->ctxt;

Edit: fix patch

@DeedleFake looks like this is a breaking change in libxml2 2.12 [1], we'll need a patch. If someone finds an upstream patch or writes one we can include it.

[1] https://gitlab.gnome.org/GNOME/libxml2/-/issues/642#note_1937004

The build's been failing for me for a few weeks now.

xml.c:1023:45: error: incompatible function pointer types passing 'void (void *, xmlErrorPtr)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        xmlSetStructuredErrorFunc((void *) errcxt, xml_errorHandler);
                                                   ^~~~~~~~~~~~~~~~
/usr/include/libxml2/libxml/xmlerror.h:898:29: note: passing argument to parameter 'handler' here
                                 xmlStructuredErrorFunc handler);
                                                        ^
xml.c:4569:55: error: incompatible function pointer types passing 'void (void *, xmlErrorPtr)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        xmlSetStructuredErrorFunc((void *) xtCxt->xmlerrcxt, xml_errorHandler);
                                                             ^~~~~~~~~~~~~~~~
/usr/include/libxml2/libxml/xmlerror.h:898:29: note: passing argument to parameter 'handler' here
                                 xmlStructuredErrorFunc handler);
                                                        ^
xml.c:4623:55: error: incompatible function pointer types passing 'void (void *, xmlErrorPtr)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        xmlSetStructuredErrorFunc((void *) xtCxt->xmlerrcxt, xml_errorHandler);
                                                             ^~~~~~~~~~~~~~~~
/usr/include/libxml2/libxml/xmlerror.h:898:29: note: passing argument to parameter 'handler' here
                                 xmlStructuredErrorFunc handler);
                                                        ^
xml.c:4769:55: error: incompatible function pointer types passing 'void (void *, xmlErrorPtr)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        xmlSetStructuredErrorFunc((void *) xtCxt->xmlerrcxt, xml_errorHandler);
                                                             ^~~~~~~~~~~~~~~~
/usr/include/libxml2/libxml/xmlerror.h:898:29: note: passing argument to parameter 'handler' here
                                 xmlStructuredErrorFunc handler);

I've fixed the checksums, although the build fails for me with python2-bin anyway.

When trying to build this package error raised:

==> Validating source files with sha256sums... postgresql-perl-rpath.patch ... FAILED

==> ERROR: One or more files did not pass the validity check!

@Wennadocta are you building and installing manually with makepkg and pacman -U? This PKGBUILD outputs multiple packages, so you'll need to install the -libs package at the same time as well. Otherwise it may be an issue with your AUR helper.

How to istall?? -> Could not find all required packages: postgresql-libs=12.11 (Wanted by: postgresql-12)

Thanks @hugleo, I've added the patch for now. I personally set !check in /etc/makepkg.conf since I've never seen a meaningful test failure.