Package Details: pcsx2-git 2.3.35.r0.g4eae1b7127-1

Git Clone URL: https://aur.archlinux.org/pcsx2-git.git (read-only, click to copy)
Package Base: pcsx2-git
Description: A Sony PlayStation 2 emulator
Upstream URL: https://github.com/PCSX2/pcsx2
Licenses: GPL-3.0+
Conflicts: pcsx2
Provides: pcsx2
Submitter: alucryd
Maintainer: weirdbeard (xiota)
Last Packager: weirdbeard
Votes: 130
Popularity: 0.138209
First Submitted: 2014-03-26 14:17 (UTC)
Last Updated: 2024-11-27 22:52 (UTC)

Dependencies (34)

Required by (4)

Sources (2)

Pinned Comments

weirdbeard commented on 2024-08-17 03:40 (UTC)

https://github.com/PCSX2/pcsx2/pull/11632

This package now enables Cmake Package mode proper. PCSX2 will here on, be installed in the package standard folders /usr/bin, /usr/share, /usr/lib. Following the XDG standard pcsx2's config files remain in .config/PCSX2

In order to ensure a proper and clean upgrade. Uninstall this package COMPLETELY and clear cache before reinstalling.

Latest Comments

« First ‹ Previous 1 .. 5 6 7 8 9 10 11 12 13 14 15 .. 67 Next › Last »

xmusjackson commented on 2024-06-04 23:52 (UTC) (edited on 2024-06-05 00:00 (UTC) by xmusjackson)

I don't understand what that has to do with this issue. The patchset is maintained by the pcsx2 devs and located in the source, so what maintenance are you doing? If we follow the same process the devs use to build the appimage, this is what we get. This is the only library dependency this build uses that's not used as it (and not linked in).

Really my biggest issue is that I've never seen a package copy a whole library from another package during it's install script, in cases where something like this is necessary, the custom library is built with a unique name or is placed in a subdirectory inside /lib (as this package does currently). However, instead of building pcsx2 to look for the library there, the rpath is skipped by the build command and the library is copied out of the live system into another place in the live system.

I can't say I understand why you would solve this dependency this way, and I don't understand how your comment is relevant to the issue of separately packaging this unique custom library, but if you are truly insistent that they should be separate packages then you should at least modify the PKGBUILD for PCSX2 to build the binary with an rpath pointing to /usr/lib/shaderc_non_semantic_debug as copying a system library that's only used by one program and then leaving it on the system in two places completely defeats the purpose of creating a separate package.

weirdbeard commented on 2024-06-04 21:36 (UTC)

The reason I don't do that is because with the original patch came several issues that caused more and more patches to pile up

https://git.launchpad.net/~tellowkrinkle/pcsx2-github-mirror/commit/?id=7095850c1875a0183ffd273935a44aef81585f71

Eventually, it becomes a maintenance nightmare of patch after patch, especially if more patches are added in the future. (Note that there's maybe a patch or two listed in there irrelevant to this point.)

xmusjackson commented on 2024-06-04 19:32 (UTC) (edited on 2024-06-04 19:39 (UTC) by xmusjackson)

Note: I originally worked on this because of the package conflict between shaderc and shaderc-non-semantic-debug, but that issue was resolved when the shaderc-non-semantic-debug package was revised. However, I believe this is still relevant as requiring pcsx2 to depend on a separate package containing a modified version of shaderc that will only ever be used by pcsx2 seems unnecessary.

A better approach (imo) would be to build the custom shaderc with pcsx2 and simply copy that into the directory containing the pcsx2 binary. This package even takes the custom shaderc installed via the aur package and copies it to /opt/pcsx2, which makes having that package installed unnecessary.

Here is a git repo with the changes mentioned: https://github.com/xmusjackson/pcsx2-git

It builds in a clean chroot (given you provide libbacktrace-git as an install dependency) and works as expected.

rubin55 commented on 2024-06-03 18:56 (UTC)

I think you need to add shaderc-non-semantic-debug to makedepends too.

dujemiha commented on 2024-05-31 07:58 (UTC) (edited on 2024-05-31 07:58 (UTC) by dujemiha)

libbacktrace (provided by libbacktrace-git) should be added to depends, otherwise this error occurs:

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Libbacktrace (missing: LIBBACKTRACE_LIBRARY
  LIBBACKTRACE_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindLibbacktrace.cmake:20 (find_package_handle_standard_args)
  cmake/SearchForStuff.cmake:72 (find_package)
  CMakeLists.txt:39 (include)

weirdbeard commented on 2024-05-18 15:18 (UTC)

Well, I'm the one who created the non-semantic debug package. That said, If it becomes irrelevant yeah we can switch around. My understanding is he's going to make other patches for it at some point So there might also be some flipping back.

As for trying to impress them, honestly, I don't care to impress them. But if I can hold a candle of goodwill towards keeping the package somewhat in line with their AppImage then I will.

« First ‹ Previous 1 .. 5 6 7 8 9 10 11 12 13 14 15 .. 67 Next › Last »