@kstolp Thanks for taking on the package, and for incorporating the encryption features, finally! Will now close https://github.com/eli-schwartz/pkgbuilds/issues/30
One thing I noticed, not related to encryption though, when diffing your changes towards previous zfs.initcpio.install was this:
- [[ -f /etc/hostid ]] && add_file "/etc/hostid"
While looking through the git history for that file, the commit which added it mentions this:
commit f18efa1dc42e700fcca9dd689d3093af14023cf8
Author: Eli Schwartz <eschwartz@archlinux.org>
Date: Mon Mar 4 16:59:44 2019 -0500
upgpkg: zfs-utils 0.7.13-1
upstream release
Restore hostid handling erroneously removed long ago by archzfs -- not
enforcing its use by default is reasonable, ignoring it when it is
present and explicitly desired by the user, is not reasonable.
In my case it doesn't matter, I don't have that file, but was there a valid reason for removing it (again)?
Also, for future commits, it might be nice to include where the changes comes from, mainly for traceability but also for giving credits to other contributors I guess (archzfs in this case, which isn't really explicitly said anywhere). For example, zfs-utils.initcpio.hook in current master (97f20df49429) is a copy of https://raw.githubusercontent.com/archzfs/archzfs/be2470f56d3d6c5092caf2a28db67046cc4a5700/src/zfs-utils/zfs-utils.initcpio.hook
Thanks again!
Pinned Comments
eschwartz commented on 2020-12-27 22:43 (UTC)
@Win8Error,
This package doesn't support people who have failed to read the wiki page https://wiki.archlinux.org/index.php/Makepkg, or cannot interpret error messages.
eschwartz commented on 2019-10-16 03:49 (UTC)
aarch64 is not an officially supported architecture for this PKGBUILD, since I don't exactly test it on such architectures. It failing to work is therefore not very surprising.
I guess you can do any necessary followup in that upstream bug report, hopefully upstream can get it into a state of "working out of the box" so that makepkg --ignorearch works. But I'm not investing any of my own time in this...