As I mentioned, I'm not going to use the "system" electron anymore, that's it. Feel free to create a vesktop_electron
package for that.
Regarding pnpm
I don't see how it goes against the guidelines.
Git Clone URL: | https://aur.archlinux.org/vesktop.git (read-only, click to copy) |
---|---|
Package Base: | vesktop |
Description: | A standalone Electron-based Discord app with Vencord & improved Linux support |
Upstream URL: | https://github.com/Vencord/Vesktop |
Keywords: | discord vencord vesktop |
Licenses: | GPL-3.0-only |
Conflicts: | vesktop-electron |
Provides: | vesktop |
Submitter: | picokan |
Maintainer: | Edu4rdSHL (Covkie, zt64) |
Last Packager: | Covkie |
Votes: | 34 |
Popularity: | 7.52 |
First Submitted: | 2024-01-16 08:05 (UTC) |
Last Updated: | 2024-09-20 02:58 (UTC) |
« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 Next › Last »
As I mentioned, I'm not going to use the "system" electron anymore, that's it. Feel free to create a vesktop_electron
package for that.
Regarding pnpm
I don't see how it goes against the guidelines.
Hello! First of all, thank you for taking some time to fix the breakage. I have removed the workaround I mentioned in a previous post, and no crashing thus far. :D
However, I would like to suggest depending on an explicit version of Electron, i.e. electron30
instead of electron
(in a timeline where this Wayland issue didn't exist; so electron29
in this timeline). I have the following rationale:
electron-flags.conf
)Additionally, the build()
step downloads some files (via pnpm
), which goes against the PKGBUILD guidelines; I personally don't care much, but someone might later, so it's still worth considering IMO?
I am willing to donate some of my own time to patch the PKGBUILD appropriately; LMK if you'd be interested, and if your PKGBUILD is hosted on a public repo (like mine) so I could send you PRs there instead.
I'm not going to use “system” electron anymore on this package as it's proven to create issues. As Vendicated mentioned, if anyone wants that, feel free to create a vesktop_electron
package or something.
This package holds the “base” package name and should be as close as possible to the official build process.
Using electron29 would still "force" people who had no problems with electron30 to install multiple versions of electron.
But that's already happening with the bundled electron, so nothing will change. At least if it uses electron29
people with that package installed will get to avoid it.
If you're suggesting that this package should revert back to electron 30, I think the people having issues with it should take priority, especially since one of the devs of vesktop came here and asked the maintainer to downgrade it.
Wouldn't it be better ... won't be forced to have a second redundant installation ...
Using electron29 would still "force" people who had no problems with electron30 to install multiple versions of electron.
Wouldn't it be better to use electron29
instead of bundled electron? That way, electron 30 will not be used and people who already have electron29
installed won't be forced to have a second redundant installation of it.
1.5.1-2
should fix all the issues with Wayland, as it uses the bundled app's electron.
Hi, Vendicated. As xiota mentioned, if there had been one open issue that we can track and see the impact it's having, I would have been able to address it sooner. But as I rely solely on the electron issue, and I haven't seen many interactions there I hold it.
Now, I have checked the electron issue again, and it has a bit of more activity, I'm going to use the vesktop bundled electron for the package from now on.
Cheers.
there have been like 10 github issues
If an issue were kept open, users could complain in one place, rather than keep opening new ones.
hello, project maintainer here
seems that only a few users are having the issue
it probably seems that way because noone is complaining to you. most users instead report this upstream and add a lot of noise to our issue tracker and support channel. there have been like 10 github issues related to this issue already with multiple people replying on each, and even more people complaining in support. so no, this is not an issue only a few users have, this is a major problem that essentially makes this package broken
if you're gonna package the app, please stick to proper stable electron versions officially supported by us, especially considering you hold the very prominent "vesktop" name which makes it seem official. if you want to experiment with newer electron versions, it would be better to create a separate package akin to the discord_electron package
on a different note, why does this package provide "vencord"? this is vesktop, not vencord. vencord is a different project. it should provide "vesktop"
Pinned Comments
Edu4rdSHL commented on 2024-09-17 03:25 (UTC) (edited on 2024-10-27 20:33 (UTC) by Edu4rdSHL)
As of 2024-09-16, this package is being co-maintained by official vesktop developers, and any packaging decisions they make will not be questioned on my part unless it's something harmful for the users, which is very unlikely to happen. As I see it coming, they will not use the system's electron on this package purposely, if you don't like it, use
vesktop-electron
, which is also maintained by the same devs.Thanks!