I just checked the app.asar
contents and I saw this https://paste.rs/lKcGF, didn't see the locales and the other info there.
Search Criteria
Package Details: vesktop 1.5.3-4
Package Actions
Git Clone URL: | https://aur.archlinux.org/vesktop.git (read-only, click to copy) |
---|---|
Package Base: | vesktop |
Description: | A standalone Electron-based Discord app with Vencord & improved Linux support |
Upstream URL: | https://github.com/Vencord/Vesktop |
Keywords: | discord vencord vesktop |
Licenses: | GPL-3.0-only |
Conflicts: | vesktop-electron |
Provides: | vesktop |
Submitter: | picokan |
Maintainer: | Edu4rdSHL (Covkie, zt64) |
Last Packager: | Covkie |
Votes: | 35 |
Popularity: | 7.56 |
First Submitted: | 2024-01-16 08:05 (UTC) |
Last Updated: | 2024-09-20 02:58 (UTC) |
Dependencies (6)
- alsa-lib
- gtk3 (gtk3-no_deadkeys_underlineAUR, gtk3-classicAUR, gtk3-classic-xfceAUR, gtk3-patched-filechooser-icon-viewAUR)
- nss (nss-hgAUR)
- nodejs (nodejs-lts-fermiumAUR, nodejs-gitAUR, python-nodejs-wheelAUR, nodejs-lts-hydrogen, nodejs-lts-iron) (make)
- libnotify (libnotify-gitAUR) (optional) – Notifications
- xdg-utils (busking-gitAUR, xdg-utils-slockAUR, mimiAUR, mimi-gitAUR, xdg-utils-handlrAUR, openerAUR, xdg-utils-mimeoAUR, mimejs-gitAUR) (optional) – Open links, files, etc
Required by (3)
Sources (4)
Latest Comments
« First ‹ Previous 1 .. 3 4 5 6 7 8 9 10 Next › Last »
Edu4rdSHL commented on 2024-01-31 20:10 (UTC)
picokan commented on 2024-01-31 07:55 (UTC) (edited on 2024-01-31 09:48 (UTC) by picokan)
@Edu4rdSHL It's not copying the binary with the embedded electron anymore, but it's still copying a bunch of other unneeded files. The only file in /usr/lib/vesktop
should be app.asar, everything else is not needed because they are already in the app.asar file itself. The "Total installed size" of the package should be around the size of app.asar.
When you say it wouldn't build on users that don't have any electron in their system, what exactly was happening? electron
was in depends
already, was it not being installed as a dependency of this package? Because I just tried installing this package with the PKGBUILD from commit cbeccae40c3c6674e852715e17fa038a5ad23920
in a system without electron installed, and it worked just fine.
Edu4rdSHL commented on 2024-01-31 02:35 (UTC)
@picokan, is -12 okay?
Total Download Size: 27.00 MiB
Total Installed Size: 92.88 MiB
Net Upgrade Size: -169.11 MiB
Edu4rdSHL commented on 2024-01-31 02:25 (UTC)
@picokan, the way the package was before makes it to not build on a clean chroot environment or on users who doesn't have any electron on their system.
Edu4rdSHL commented on 2024-01-31 02:24 (UTC)
@EinfxchFinn, fixed.
EinfxchFinn commented on 2024-01-30 09:00 (UTC)
Yes, afaik you only need to copy the app.asar if you are using the system electron.
picokan commented on 2024-01-30 07:48 (UTC)
Yeah, can you leave it as it was please? I'm running vesktop as it was before you started changing the PKGBUILD, and I have everything working: locales, vc, etc. Every single feature works as intended with no breakages.
All of those files are embedded into the app.asar
file, which are being duplicated when installed this way. When I run pacman -U on your package, the installation size goes from 25.82MB to 261.99MB.
You can still leave it with supporting only the latest electron, but please at least change it back to use the system electron. If needed, re-add me as a co-maintainer and I'll keep taking care of those aspects.
EinfxchFinn commented on 2024-01-30 07:13 (UTC)
Since 1.5.0-10, when Electron was removed from the dependencies, Vesktop now throws "/usr/bin/vesktop: line 11: exec: electron: not found" and won't start anymore, because the startup script still uses the system electron to start Vesktop.
Edu4rdSHL commented on 2024-01-29 19:54 (UTC)
Well, after checking, if we do not copy the whole thing to /usr/lib
we don't get:
- locales
- some required libraries that are built-in
- some soname libraries
- more
The list of files generated actually are https://paste.rs/2uml1.txt
The right thing here is to just let it build as it's actually, remove electron from the dependencies and that's it. Even if we do something like discord_arch_electron
, we need to add a fixed electron version for the package. Dropping the electron dependency for now.
Edu4rdSHL commented on 2024-01-29 19:45 (UTC) (edited on 2024-01-29 19:47 (UTC) by Edu4rdSHL)
@picokan packages are meant to build in a clean chroot environment (which was not happening because a clean chroot environment doesn't have any electron right there, and it will fail if the user didn't had any electron version installed on the machine too), not the user-specific environment, so we need to add a defined electron version in there, which is the system's electron. If you need, you can just update your PKGBUILD locally and add electron27
to the dependencies.
I will check the binary that's being copied.
Pinned Comments
Edu4rdSHL commented on 2024-09-17 03:25 (UTC) (edited on 2024-10-27 20:33 (UTC) by Edu4rdSHL)
As of 2024-09-16, this package is being co-maintained by official vesktop developers, and any packaging decisions they make will not be questioned on my part unless it's something harmful for the users, which is very unlikely to happen. As I see it coming, they will not use the system's electron on this package purposely, if you don't like it, use
vesktop-electron
, which is also maintained by the same devs.Thanks!