Hello! First of all, thank you for taking some time to fix the breakage. I have removed the workaround I mentioned in a previous post, and no crashing thus far. :D
However, I would like to suggest depending on an explicit version of Electron, i.e. electron30
instead of electron
(in a timeline where this Wayland issue didn't exist; so electron29
in this timeline). I have the following rationale:
- This avoids having an extra copy of Electron on the system. The usual arguments about minor+patch releases also apply there.
- This also keeps the Electron behaviour consistent with Arch tweaks (such as
electron-flags.conf
) - This is indeed some more work when upgrading this package, but I think that it's a reasonable amount
Additionally, the build()
step downloads some files (via pnpm
), which goes against the PKGBUILD guidelines; I personally don't care much, but someone might later, so it's still worth considering IMO?
I am willing to donate some of my own time to patch the PKGBUILD appropriately; LMK if you'd be interested, and if your PKGBUILD is hosted on a public repo (like mine) so I could send you PRs there instead.
Pinned Comments
Edu4rdSHL commented on 2024-09-17 03:25 (UTC) (edited on 2024-10-27 20:33 (UTC) by Edu4rdSHL)
As of 2024-09-16, this package is being co-maintained by official vesktop developers, and any packaging decisions they make will not be questioned on my part unless it's something harmful for the users, which is very unlikely to happen. As I see it coming, they will not use the system's electron on this package purposely, if you don't like it, use
vesktop-electron
, which is also maintained by the same devs.Thanks!